search

Dreamescaper / GenerateAspNetCoreClient

DotNet tool to generate HTTP client classes from ASP.NET Core api controllers.
MIT License
63 stars 5 forks source link

Generator dont check for query names #4

Closed valentasm1 closed 3 years ago

valentasm1 commented 3 years ago

Lets say we have Action like this

GetThing(string language, [FromQuery(Name = "culture")] string? languageCulture)

It generates

GetThing(string language, string languageCulture = null);

which should be

GetThing(string language, [AliasAs("culture")]  string languageCulture = null);

Or

GetThing(string language, string culture= null);
valentasm1 commented 3 years ago

Workaround would be just name languageCulture > culture

Dreamescaper commented 3 years ago

Thanks for reporting! I've published updated version.

valentasm1 commented 3 years ago

I wanted to complain why you closed this without fixing, since it looked to fast to fix it in that short time. After double check i realised that you fixed it. Super fast. Thank you .