Dreamescaper / IntelliSenseExtender

GNU General Public License v3.0
90 stars 17 forks source link

Private method extensions are suggested #57

Closed micdenny closed 5 years ago

micdenny commented 5 years ago

I don't expect the intellisense to show me the private methods extension took from external dependencies, because actually you cannot access those methods from outside the library it declares it.

Private methods extension should be suggested only when they come from the same project/library/dll where I'm writing code.

Dreamescaper commented 5 years ago

Certainly shouldn't be like that. Private member shouldn't be added by extension at all - they make sense only in declaring class, and VS does that on its own.

Is that about extension methods? Could you provide any example?

micdenny commented 5 years ago

Is that about extension methods?

yes

Could you provide any example?

coming... hold on

micdenny commented 5 years ago

sample: IntelliSenseExtenderPrivateExtensionMethods.zip

image

then when the using is imported of course the private method doesn't shows up anymore:

image

image

Dreamescaper commented 5 years ago

Yep, my bad. I checked for class accessibility, but not for member itself.

Dreamescaper commented 5 years ago

Thanks a lot for reporting the issue, and for great sample! Fixed, will publish to marketplace a bit later.

In the meanwhile you can test it from latest Appveyor build: https://ci.appveyor.com/api/buildjobs/pu81ry5d9qk0vpcq/artifacts/IntelliSenseExtender%2Fbin%2FRelease%2Fnet472%2FIntelliSenseExtender.vsix