Dreaming-Codes / nvidia_oc

A simple command line tool to overclock Nvidia GPUs using the NVML library on Linux. This supports both X11 and Wayland.
https://crates.io/crates/nvidia_oc
MIT License
50 stars 1 forks source link

Add support for "doas". #4

Closed somewhatfrog closed 1 month ago

somewhatfrog commented 2 months ago

Currently it doesn't work if "sudo" is not present in the system and have to be run as "doas". Though it is not a big deal if run as service it seems, otherwise app works great! Thanks!

Dreaming-Codes commented 2 months ago

This https://github.com/Dreaming-Codes/nvidia_oc/commit/8d4374bc57099c4912890f2f3a18662d1168ff8b should have added doas support but I've not tested it. Let me know if it works. That commit first appears in version 0.1.12

somewhatfrog commented 2 months ago
thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sudo2-0.2.1/src/lib.rs:174:52:
failed to execute child: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

before it was sudo-0.6.0

Dreaming-Codes commented 2 months ago

I think I know what I've missed for doas support I'll take at it later when I'm back at my hotel

somewhatfrog commented 2 months ago

sorry my bad, forgot to run it with parameters and thought it is fixed, issue is still present

Dreaming-Codes commented 2 months ago

sorry my bad, forgot to run it with parameters and thought it is fixed, issue is still present

I completely forgot too, I'll push a fix soon

Dreaming-Codes commented 2 months ago

@somewhatfrog could you please try it now?

somewhatfrog commented 2 months ago

thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sudo2-0.2.1/src/lib.rs:174:52:
failed to execute child: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Dreaming-Codes commented 2 months ago

@somewhatfrog oh, it appears that sudo2 panic instead of returning an error... I should have addressed this in 0.1.14 let me know if it works

somewhatfrog commented 1 month ago

works as of 0.1.15, closing

thank you!