Updated composer.json to properly reflect the php/ldap version requirements

Dreamscapes / Ldap-Core

Object encapsulation of PHP's native ldap functions

dreamscapes.github.io/Ldap-Core

BSD 3-Clause "New" or "Revised" License

10 stars 1 forks source link

Updated composer.json to properly reflect the php/ldap version requirements #1

Closed tpavlek closed 9 years ago

tpavlek commented 9 years ago

The version constraint didn't accurately reflect that certain versions of PHP (eg. 5.5.9) were insufficient for ldap_modify_batch.

robertrossmann commented 9 years ago

Hi!

I ultimately decided to make the ldap_modify_batch support optional, just like ldap_escape, thus lowering the PHP requirement back to >=5.4. Check out the new 2.0.0 release!

Also, I am wary of putting ext-ldap as a requirement because this would prevent tests to be run on Travis - the module is not available on Travis and I have not found a way of enabling it so far...

Anyway, thanks for PR - feedback is always welcome!

tpavlek commented 9 years ago

That's absolutely fine! As long as the composer.json reflects what's actually required.

For the record, the fix for ldap with travis was resolved in this issue: https://github.com/travis-ci/travis-ci/issues/1096 - I had the same problem earlier this year :)

robertrossmann commented 9 years ago

Ha, awesome! Added, tested, published as 2.0.1.