Dreckr / Worker

Utility for easy concurrency with isolates
MIT License
35 stars 10 forks source link

Task.execute MUST return a value or the returned future never completes #8

Closed dkornishev closed 10 years ago

dkornishev commented 10 years ago

Adding explicit return statement without a value does not remedy the situation. Only returning something (anything) causes the future to complete.

Few examples below:

void execute() {
    print("Executing");
}
void execute() {
    return new Future(() {
       print("Executing");  
    });
}
Dreckr commented 10 years ago

Thanks for reporting! Fixed on bea10a951f32ebcb29911b3568cf956a29323aa9.

Any other small fix that I can do for the next release?

dkornishev commented 10 years ago

I am currently trying to splice worker into dherkin, so I report issues as I find them.

Great work on the library, btw. Probably easiest concurrency ever :)

Dreckr commented 10 years ago

Awesome and thanks!

I'll release 0.3.10 and if have any suggestions about the API or documentation, you can email me anytime. It's great to get some feedback.