search

DreenDex / ImprovedBackpacks-Issues

Issues repo for Minecraft mod Improved Backpacks
2 stars 1 forks source link

Server errors when placing backpack on ground. Sometimes crashes #11

Open infamyreloaded opened 5 years ago

infamyreloaded commented 5 years ago

Description: Server crash. Might be related to placing backpacks on the ground. When you place a backpack on the ground it puts a bunch of errors in console. I dont know if this is what causes the crash but the server also sometimes crashes and says something about backpacks so Ill leave that here as well. Just trying to figure out the cause.

Log files: Server Log - https://hastebin.com/ehixihunev.php Crash Log - https://hastebin.com/odayinafax.php What errors - https://hastebin.com/akifujedub.php (sponge thing at the end)

To Reproduce:

  1. Shift right click a backpack to place on the ground

Expected behavior: It not do this and dont crash the server

Screenshots (If applicable): None

Additional information: Minecraft: 1.12.2 SpongeAPI: 7.1.0-70763aa8 Sponge: 1.12.2-7.1.4 SpongeForge: 1.12.2-2768-7.1.4 Minecraft Forge: 14.23.5.2807 Minecraft Forge: 14.23.5.2807 ImprovedBackpacks version: ImprovedBackpacks-1.12.2-1.4.0.0.jar

socolio commented 5 years ago

It seems that this is a very strange bug of Sponge... but we will try to do something.

infamyreloaded commented 5 years ago

Ok thank you for taking the time to look into it!

infamyreloaded commented 5 years ago

Any update on this? We can't use the mod until the crash bug is fixed :/

yepidoodles commented 5 years ago

Just adding my report https://gist.github.com/yepidoodles/da02cf99559c4daecd066e1177afcd23

Edit: As far as I'm aware, this crash only happens when it's placed next to a tinkers' crafting table

xxxLEOPARDxxx commented 5 years ago

https://gist.github.com/xxxLEOPARDxxx/8549d749eb228a112fcda1bf2f6d4459

The server falls only when I put the backpack on the ground. Please correct this, please ...

infamyreloaded commented 5 years ago

Just adding my report https://gist.github.com/yepidoodles/da02cf99559c4daecd066e1177afcd23

Edit: As far as I'm aware, this crash only happens when it's placed next to a tinkers' crafting table

Just want to add to this. The modpack I'm running doesn't have tinkers installed. So there is another thing/block that can cause the crash.

NovaLynxie commented 5 years ago

It seems I am not the only one seeing this crash problem. Hopefully, this can provide some additional information. https://gist.github.com/NovaLynxie/45242b51b1ded4b7cd539adf1ed24621

CaptainSisko commented 5 years ago

I reported this issue to the sponge devs and they have said that this is an issue with ImprovedBackpacks and not Sponge.

The recommended fix is to not override getTileData to call writeToNbt.

An explanation for this fix can be found here https://github.com/JurassiCraftTeam/JurassiCraft2/issues/561#issuecomment-483715610

The following code on lines 136 to 141 in TileEntityBackpack.class is likely the culprit.

public NBTTagCompound getTileData()
{
    NBTTagCompound tag = super.getTileData();
    func_189515_b(tag);
    return tag;
}
Rsslone commented 4 years ago

Unfortunately this issue still is happening :(