DreierF / MyTargets

Android app, which helps archers keep track of their training progress
GNU General Public License v2.0
81 stars 44 forks source link

Clean checkout will not compile #391

Closed mrj9600 closed 4 years ago

mrj9600 commented 4 years ago

I have made a clean checkout and executes gradlew.bat from root directory. This gives the following errors: Configure project :app GMS secret is missing!

FAILURE: Build failed with an exception.

mrj9600 commented 4 years ago

I have managed to build the project by removing varioud google play and signing sections from build.gradle file (locally). I guess my issue is that I dont have a developer key as I have never deployed any app to google play store.

williamvds commented 4 years ago

For those who hit the same issue, the problematic plugins are com.github.triplet.play and io.fabric. I applied the following changes and can build with gradle assembleRelease -x test. If you want tests you may want to add android { lintOptions { abortOnError false } } so linting errors don't fail the build.

diff --git a/app/build.gradle b/app/build.gradle
index 4b9d3b78..24b46dcd 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -14,14 +14,14 @@
  */
 plugins {
     id 'com.android.application'
-    id 'com.github.triplet.play' version '2.2.0'
+    // id 'com.github.triplet.play' version '2.2.0'
     id 'com.getkeepsafe.dexcount'
 }

 apply plugin: 'kotlin-android'
 apply plugin: 'kotlin-kapt'
 apply plugin: 'kotlin-android-extensions'
-apply plugin: 'io.fabric'
+// apply plugin: 'io.fabric'
 apply plugin: 'androidx.navigation.safeargs'

 android {
@@ -51,6 +51,7 @@ android {
         // "pm clear" command after each test invocation. This command ensures
         // that the app's state is completely cleared between tests.
         testInstrumentationRunnerArguments clearPackageData: 'true'
+        multiDexEnabled true
     }

     sourceSets {