Drekin / win-unicode-console

A Python package to enable Unicode support when running Python from Windows console.
MIT License
103 stars 12 forks source link

Broken on Python 3.6 #34

Open e00E opened 7 years ago

e00E commented 7 years ago
Python 3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 08:06:12) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import win_unicode_console
>>> win_unicode_console.enable()
>>> import sys

Python has stopped working Windows error message and interpreter closes.

Drekin commented 7 years ago

One thing is that win_unicode_console usually not needed at all on Python 3.6.

e00E commented 7 years ago

Youre right, 3.6 changed the console encoding to utf-8. However I also used win-unicode-console to make the default text file encoding utf-8 which is still cp1252 on 3.6 on Windows but i dont know if you want to support this feature.

Drekin commented 7 years ago

There may definitely be some other features win-unicode-console may be used for, and crashing shouldn't occur in any case, so this should be fixed.

But how did you use WUC to affect default text file encoding? AFAIK WUC doesn't do this.

e00E commented 7 years ago

Ah, I was wrong. I thought a script of mine worked with 3.5 and win-unicode-console but failed in 3.6 when writing some unicode to a text file. I just tested everything again and this wasnt case. You are correct that win-unicode-console doesnt do that.