search

Drenso / symfony-oidc

This project contains the Symfony OIDC bundle, which is directly based on https://github.com/jumbojett/OpenID-Connect-PHP
Apache License 2.0
54 stars 32 forks source link

Implement InteractiveAuthenticatorInterface #39

Closed hockdudu closed 12 months ago

hockdudu commented 12 months ago

As stated in https://symfony.com/doc/current/security/custom_authenticator.html, custom authenticators with an interactive login must implement InteractiveAuthenticatorInterface in order for the event InteractiveLoginEvent to be dispatched.

bobvandevijver commented 12 months ago

Always nice to find inconsistency! From the documentation:

If your login method is interactive, which means that the user actively logged into your application, you may want your authenticator to implement the InteractiveAuthenticatorInterface so that it dispatches an InteractiveLoginEvent

But from the interface itself:

This is an extension of the authenticator interface that must be used by interactive authenticators.

Must != may, so I opened a PR at Symfony to change the wording: https://github.com/symfony/symfony/pull/51711.

But, I see no harm in adding it to this bundle, so thank you for this! 👍🏻

hockdudu commented 12 months ago

Thanks! :heart: