Drental / fvtt-tokenactionhud

Creating a token action HUD module for Foundry VTT
31 stars 68 forks source link

[Performance] Token stutters when moving it around scene if modules with additional GUI are loaded and visible #165

Closed Hargrim closed 1 year ago

Hargrim commented 2 years ago

Hi,

I encountered this issue when using Token Action HUD and SmallTime and / or Always HP. Basically the token lags if there are any other GUI elements loaded in the world. I recorded a video using Always HP because it got a button to turn it on and turn it off to better illustrate the issue.

I'm using latest versions of the modules.

What I found out so far:

Exact behavior: https://webm.red/view/pwDV.webm

image

passiveinception commented 2 years ago

I can confirm this issue, but my stutters are much more pronounced.

For me it is an interaction with Monk's Token Bar and causes the same stuttering of the token as it moves. However, I did note that, with only Monk's Token Bar and Token Action HUD enabled, it did not cause an issue. Turning on more plugins, I found that the combination of DnD 5th Edition Journal Styling with the other two started the issue again (though it was fine by itself with Token Action HUD).

So all three together cause the issue, but either one with Token Action HUD does not -- unless I have all of my modules activated, then it will happen with either of the other plugins activated, but not with both deactivated. There must be another, similar interaction going on, but I can't find it. I have attached my (extensive, but up to date as of today, outside of Minimal UI) module list. Hopefully this has been helpful. :)

Active Modules:
----------
About Time v;
Active-Auras v;
Active Token Effects v;
Advanced Macros v;
Adventure Music v;
Ambient Doors v;
Argon - Combat HUD v;
Autocomplete Inline Properties v;
Automated Animations v;
Automated Evocations - Companion Manager v;
Auto-Rotate v;
Baileywiki Maps Pack v;
Better Roll Tables v;
Better Roofs v;
Border Control v;
Caeora's Maps, Tokens, and Assets v;
Camera View Settings v;
Cautious Gamemaster's Pack v;
Changelogs & Conflicts v;
Character Actions List dnd5e v;
Chat Portrait v;
Combat Utility Belt v;
CommunityLighting by Blitz v;
Compact DnDBeyond 5e Character Sheet v;
Compendium Folders v;
Crash's Tracking & Training (5e) v;
Darkraven Games Free Fantasy and Sci-Fi Soundscapes v;
D&D 5th Edition PHB Journal Styling v;
D&D Beyond Importer v;
DF Architect v;
DF Curvy Walls v;
DF Quality of Life v;
DFreds Convenient Effects v;
DFreds Droppables v;
Dice So Nice! v;
Dice Tray v;
DnD5e Drag Ruler Integration v;
DnD5e Helpers v;
Dnd5e Helpers Cover Expansion v;
Domille's Wondrous Works - Battlemap Collection v;
Dragonfire Maps v;
Drag Ruler v;
Dr. Mapzo free maps (unofficial) v;
Drop Effects on Items v;
Dynamic Active Effects SRD v;
Dynamic effects using Active Effects v;
Easy Target v;
Enhanced Terrain Layer v;
Fantasy Plants Compendium v;
Find the culprit v;
Forien's Quest Log v;
Forien's Unidentified Items v;
FoundryVTT Arms Reach v;
FoundryVTT Mount Up! v;
FXMaster v;
GM Screen v;
GM Secret Block v;
Grid Scale Menu v;
Illandril's Chat Enhancements v;
Illandril's Hotbar Uses v;
Illandril's Inventory Sorter (5e) v;
Inventory+ v;
Item Effects to Chat DnD5e v;
Item Macro v;
Jack Kerouac's Animated Maps v;
Jack Kerouac's Animated Spell Effects v;
Jack Kerouac's Animated Spell Effects: Cartoon v;
Jack Kerouac's Animated Tokens v;
JB2A - Jules and Ben's Animated Assets - Free Content v;
Kobold Press OGL Compendium v;
Less Fog v;
Let Me Roll That For You! v;
Let's Trade 5e v;
Levels v;
lib - Color Settings v;
Lib: Document Sheet Registrar v;
Library: DF Hotkeys v;
Library: Scene Packer v;
libWrapper v0;
LootsheetNPC5e v;
Loot Tavern Free Item Compendium v;
Lordu's Custom Dice for Dice So Nice v;
Meditating Munky - Free Dungeons and Forests v;
Michael Ghelfi Studios Audio Pack v;
Midi QOL v;
Midi SRD v;
Milby's Maps Free v;
Minimal UI v;
Miska's Maps - Battlemaps - Starter Pack v;
MiWwewa's Free Maps Bundle v;
Monk's Active Tile Triggers v;
Monk's Enhanced Journal v;
Monk's Hotbar Expansion v;
Monk's Little Details v;
Monk's Scene Navigation v;
Monk's TokenBar v;
Monk's Wall Enhancement v;
Moonlight Maps v;
More Hooks D&D5e v;
Moulinette Core v;
Moulinette Game Icons (module) v;
Moulinette Image Search (module) v;
Moulinette Scenes (module) v;
Moulinette Sounds & SoundPad (module) v;
Moulinette Tiles (module) v;
Multiattack 5e v;
Multiface Tiles v;
MyBeyond - D&D 5e Character Sheet Theme v;
Nice More Dice v;
Ostenwold Starter Town by Tom Cartos v;
Perfect Vision v;
Permission Viewer v;
Pin Cushion v;
Player Foundry Info (Shared Compendiums) v;
PnP - Pointer and Pings! v;
Polyglot v;
PopOut! v;
Pull Players to Scene v;
Roll From Compendium v;
Sane Magical Item Prices Compendium v;
Scene Transitions v;
Search Anywhere v;
Sequencer v;
Sidebar Expander v;
Simple Calendar v;
Simple Dice Roller v;
socketlib v;
SoundBoard by Blitz v;
SoundBoard Pack - Blitz Free Pack v;
SoundBoard Pack - Community v;
Spellarena Battlemap Collection v;
Splatter v;
Sync Token Names v;
Tabletop RPG Music v;
TacticalMap Battlemaps v;
Terrain Ruler v;
The Forge: More Awesomeness v;
The MAD Cartographer | Free Battlemap Pack v;
The Reclusive Cartographer's Free Maps v;
Tidy5e Sheet v;
Tidy UI - Game Settings v;
Times Up v;
Token Action HUD v;
Token Attacher v;
Token HUD Wildcard v;
Token Info Icons v;
Token Magic FX v;
Token Mold v;
Token Z v;
Torch v;
Video Game Music v;
VividAdventureMaps VTT Assets: Free Edition v;
VoiceActor by Blitz v;
Wall Height v;
Warp Gate v;
Weather Blocker v;
Window Controls v;
Za'hi | Cartography - Free Maps v;
Zoom/Pan Options v;

Inactive Modules:
----------
Arius Planeswalker's Stylish Journal for Monk's Enhanced Journal v;
Beyond20 companion module v;
Compendium Explorer v;
Control concealer v;
GalaxyDietJuice v;
GM Notes v;
Grape Juice Isometrics v2;
Legend Keeper Integration v;
RPG Styled UI for Foundry VTT v;
Spell Level Buttons for DnD 5e v;
Tagger v;
Whetstone - Foundry Theme Manager v;
Hargrim commented 2 years ago

I updated to 9.251 today and the issue is still there.

I also noticed that there is a lag after clicking the token before the HUD shows - there is like 0.5-1s freeze of the Foundry before everything goes back to normal. This happen only when additional GUI elements are enabled (both examples from my initial report can be used to test this).

Larkinabout commented 1 year ago

Performance improvements will continue with Token Action HUD Core.