search

Dresel / RouteLocalization

RouteLocalization is an MVC and Web API package that allows localization of your attribute routes.
MIT License
67 stars 13 forks source link

The state of ASP.NET Core branch #76

Closed kasparkallas closed 6 years ago

kasparkallas commented 6 years ago

Hey @Dresel

I am building a simple web application with localized routes and I downloaded the 1.0.0-alpha2 from NuGet.

And... It seems to work great so far!

So I was wondering what is the hold up for doing a proper release? As the "alpha" is a little bit off putting. And I think the Core version should be moved to a repository of it's own. Is there any way I could help?

Dresel commented 6 years ago

I'm happy that it works for you.

Some things were mentioned here that could be added for the initial release (or future versions). The nuget references and sample project should also be updated to 2.0.

Otherwise I'm happy if you do a bit of testing and report back anything you encounter (bugs, misunderstandings, api suggestions, etc.). If you are really motivated I'm happy to accept pull requests for the separate repository (like documentation, samples, features, ...)?

Tell me what you think and give me a week or two to prepare the migration for the separate repository and setup the initial release.

kasparkallas commented 6 years ago

I would be happy to help out. I'd say I'm medium motivated.

It took me just few minutes to update the packages in the sample project and not that long to be comfortable with the API. Nice logical fluent API. But that's exactly my point -- this deserves a repository of it's own and a non-alpha release. The library is a thin layer on top of ASP.NET Core MVC so I would not be too worried about releasing...

For future developments, I think it should be possible to configure localized routes with attributes. But it's not a big deal -- same functionality, just a different way to organize the code.

Dresel commented 6 years ago

Sounds reasonable :)

Dresel commented 6 years ago

Moved to https://github.com/Dresel/RouteLocalization.AspNetCore and upgraded to 2.0.

Still have to upgrade CI, and maybe remove unnecessary assets from the sample project and we are good to go for release 1.0.

Dresel commented 6 years ago

1.0.0 is publicly available. Feel free to add issues, suggestions (e.g. the attribute localization configuration) or anything else to the new repository.

kasparkallas commented 6 years ago

Nice! Good job and thanks, @Dresel!

I will make an effort to contribute.