Design Reconcilliation: Fonts

DrewAllen88 / Enhancements

Working enhancement list for Marsh.com.

1 stars 0 forks source link

Design Reconcilliation: Fonts #40

Open DrewAllen88 opened 9 years ago

DrewAllen88 commented 9 years ago

Font sizes to match those of the Promo Carousel from the Miller Smith designs.

Requirements:

RR People List

"" field font to be reduced to 13px
"" field font to be reduced to 14px

RR Text

"Description" field font to be reduced to 14px

RR Video

"Video Description" field font to be reduced to 14px

RR Bio

Dynamic "Title" field font to be increased to 14px

RR Horizontal Highlight

"Description" field font to be reduced to 14px

RR Vertical Highlight

"Description" field font to be reduced to 14px
"Link Label" field font to be decreased to 13px

DrewAllen88 commented 9 years ago

For dynamic fields that are pulled in, find their label in Confluence.

timproDev commented 9 years ago

@DrewAllen88 @joyjamir AEM is implementing the rt rail highlight code for the rt rail text component. The recent designs suggest that the

font sizes of these 2 components are to be different font-sizes. we could either maintain consistency across these 2 components by making the font-size 1 specific size, or we could look to enhance the rt rail highlight component code so that an alternate font-size is rendered should a class be added. since the AEM implementation is leveraging 1 component (the rt rail highlight) to act as another component (rt rail text), this sort of confusion and cross styling issues creep up. Perhaps, down the road we could look into building a rt rail text component that is not using the rt rail highlight component code.

Joy asked if I would like to be part of the UAT test team and I agreed as it might be a good opportunity for code review.

Thoughts?

joyjamir commented 9 years ago

@DrewAllen88 and @timproDev Do you think we can flag this for the next release?

DrewAllen88 commented 9 years ago

@timproDev we need to account for the text in the left body now as well. Accordion text is far too small.

joyjamir commented 9 years ago

@timproDev Do we have the body font size update that should be applied across all of the text components

joyjamir commented 9 years ago

@timproDev Sorry, an additional comment, it's not just the text components, but all of the left and main body text, including on Article templates, which are pulled in from Shared Content.

@DrewAllen88 , let's discuss this with the BAU team

DrewAllen88 commented 9 years ago

Check on this after next release 2. Some of the fonts may be template specific.