Open DrewAllen88 opened 9 years ago
@DrewAllen88 @joyjamir I have a question about the mobile view of this implementation. please see the image below. on desktop, the user can enter text into the search field and then click the magnifying glass icon to submit the request. on mobile, when the use taps the search icon, a drop down search field appears with a text button that says "search". this text button is the submit action. if we are to remove the text button that says search, would we be replacing it with a small magnifying glass, similar to on desktop? if so, then we would be presenting the user with 2 magnifying glass icon, both with different functionality. we probably don't want to do this - however, we need another solution. should we contact design?
Tim and I discussed and we are looking into ways to solve this. Based on our discussion so far, I am leaning towards an approach where we rely on the button in the keyboard as the search execution button, rather than an actual button on the interface. This will probably mean we will want to de-emphasize the magnifying class (either suppress it, keep it in the upper right, shade it, something) so users do not think it is clickable as the search execution button.
This something we all need to come to an agreement on or do we need involve Creative? This code is due next week so we need a decision.
@DrewAllen88 @ianlaw hi team - here is my proposed solution. replacing the search text with an arrow. the right arrow convention is part of the marsh web design and can be found on the right rail blue button elements. we could repurpose it here. thoughts?
@timproDev Are we moving the word "Search" into the search box on desktop too then?
On desktop move the "Search" cue text into the search field. Tablet and mobile do the same and add the right arrow to kick of the search.
I'm good with this approach. Joy, can we get your approval so Tim can start working on this?
I think I gave it yesterday? But yes, approved.
Joy, I think Ian is implying that your approval only counts after his approval....
this update includes CSS edits and will be included in the Release 3 deliverable
MAR-2379 Jira created for it. Please do not update this GITHUB ticket anymore.
Need to make it scaleable as the text is authorable. The solution is to add the search text back in as cue text to the dialog box.