Please kindly update for Cordova 3.x. Awesome plugin btw

DrewDahlman / ImageFilter

A phonegap plugin for creating instagram style filters for photos.

61 stars 29 forks source link

Please kindly update for Cordova 3.x. Awesome plugin btw #4

Open donniemceduns opened 10 years ago

quanghoc commented 10 years ago

Have anyone tried to use Javascript filter like CamanJS to accomplish this?

billmn commented 10 years ago

@quanghoc Yes but with Cordova seems to be really slow (like 15 seconda to apply a filter)

quanghoc commented 10 years ago

@billmn I'm thinking about rewriting CamanJS in an async / non-blocking way. Current bad performance is mostly due to the WebObject. iPhone 5S took about 1-2 sec but still noticable. What I did was to resize the image before processing.

billmn commented 10 years ago

@quanghoc Have you seen this? https://github.com/meltingice/CamanJS/wiki/About-the-block-renderer

travisdahl commented 10 years ago

+1 would love to use this!

quanghoc commented 10 years ago

@billmn I haven't tested block render. Did it make things faster?

billmn commented 10 years ago

Benefits:

Image rendering is asynchronous, which means page rendering is no longer blocked.
Slower filters get a nice speed improvement due to (fake) render concurrency. Of course browser JS engines are event-based and single-threaded, but by splitting up the canvas into separate chunks, we give more control to the JS engine for managing operations.

Caman already use this but is really slow yet.

I think the only way to have good performance in image processing is to take advantage of GPU ... therefore need a plugin that allows native access to hardware

DrewDahlman commented 10 years ago

Before writing this I tried caman and js rendering. The speed and quality will always lack from native.

Sent from my Delorean

On Aug 7, 2014, at 12:41 AM, Davide Bellini notifications@github.com wrote:

Benefits:

Image rendering is asynchronous, which means page rendering is no longer blocked. Slower filters get a nice speed improvement due to (fake) render concurrency. Of course browser JS engines are event-based and single-threaded, but by splitting up the canvas into separate chunks, we give more control to the JS engine for managing operations. Caman already use this but is really slow yet.

— Reply to this email directly or view it on GitHub.

travisdahl commented 10 years ago

Agreed @DrewDahlman . I just tried it, and although its cool for the web it leaves a lot to be desired on the phone. So Drew, from one Dahl-man to another, what are your thoughts on updating this? eh? ;p

mohamedsalehamin commented 9 years ago

any news about updating that