search

DrewML / octo-preview

Chrome extension for live markdown previews in GitHub comments
40 stars 10 forks source link

Breaks GitLab #8

Closed sdgluck closed 8 years ago

sdgluck commented 8 years ago

The plugin currently matches any domain, which caused me to spend some time scratching my head as to why my organisation's GitLab instance was not working on my machine only.

Can we change the value of matches in manifest.json to target GitHub only?

"content_scripts": [{
        "matches": ["*://*.github.com/*"],
        "js": ["inject.js"],
        "run_at": "document_idle"
    }],

Happy to put in a PR with this change...

Thanks for a great plugin!

sdgluck commented 8 years ago

Oops.

Already an issue for this: #5

Cheers.