Contributions etc.

[jdc20181]

If you need more help just ask, I have been developing my project for over 2 years now. It has came a long way, I created A PR to add the Document title, to your tab pages.

As far as your tab closing issue - What does it do? What is your code?

See my tab control class here it is a custom tab class - all you have to do is build your project and drop the control on your form. - it has a close button drawn on it, it isn't the best in the world, it isn't my original code either, I adapted it from another person's work, much of my code however, is my own.

I suggest migrating to GeckoFX you can install it using Nuget.

You also don't need the other class you are using to add tabs. A lot of your issues could be tied into this.

Talk again soon!

Jdc20181

[DrewNaylor]

Thank you for the help so far. I've looked at the PR and there are only a few things I'll have to change, including adding an End Region and changing the Gecko.Events.GeckoDocumentCompletedEventArgs to the IE equivalent. I may not do this tonight as it's late, though.

Currently, closing tabs is not yet implemented.

I've taken a look at the tab class and it looks nice, though my browser is licensed under GPLv3 and I'm not sure if I can mix it with controls/code under the MIT license or how to do it if possible. I've looked into mixing licenses and haven't found anything concrete yet. Do I just add the tab class file to my project and build then use it?

I've actually been thinking about using GeckoFX but last I tried to use it (and now), it was still at version 45 while Firefox is at version 54 already. Although I guess it doesn't matter that much as I'm using IE, which is generally worse than most other browsers.

A lot of my GitHub issues I've made are just things I've thought about and wanted to write down so I didn't forget them.

Even while making the new tab class I knew it wasn't the best, but didn't really know anything better. Especially while using all those Tags. The reason why it's in another class is just to separate stuff as much as possible.

For now I just want a good add/remove tab system, and later add the close button, page favicon, and document title. Probably document text sooner than close button, followed by page favicon. I'm pretty sure using Tags is a bad way to manage browsers in different tabs. In fact, I noticed you're using a CType to access the browser which probably helps with resources. I changed the way I access my browsers in each tab to CType for at least the Reload button.

I'll have to list you as a contributor at least in the About window (when I switch to the one from my launcher which I want to do soon hopefully,) and the Wiki with a link to the Contributors wiki page from the Readme, if that's ok with you.

Again, thank you for your help.

[jdc20181]

Fav icon is the only thing I've never been able to accomplish. Yes I was told to use Ctype when I first began and it may help with your other issues I do not know. I used the code I knew would work.

Gecko is much better, and yes it's about 10 behind in the stable on that's about a year old. If you use VS 15 or newer you will get a error which is in the XML, if you need help with that if you decide to use Gecko, simply let me know and I'll send you to where I got my help at.

However if you prefer IE (which would be strange) you can use another class I posted in another issue, to upgrade your I.E. control to use the latest release

I've been in a forum for almost 2 years it helped greatly to grow my knowledge.

Yes- because I "own" the class, as far as I'm concerned I can do as I please with my code. Take the tab control, paste it into a "class file" (rename it to Tabcontrol you have yours name to) build your project take a look in your Toolbox and you'll see it.

And sure, that's fine.

You can use Ctype blah blah selected tab. Remove or something like that to get tabs to remove you have to make sure you're going by the selected tab or it won't work correctly.

Yea I do that, it helps remember things to do but doesn't always have the knowledge remembered on a fix.

i would ditch the whole tab class thing you have. And put everything in a region together.

And Gecko 45 isn't that old it's only a year. So while we may have less performing browsers, the Gecko bitbucket hasn't been updated in a while- so we got what we are going to get.

I'll be contributing more I had to go or I would have done more while I was working.

On Fri, Jul 7, 2017 at 1:45 AM Drew Naylor notifications@github.com wrote:

Thank you for the help so far. I've looked at the PR and there are only a few things I'll have to change, including adding an End Region and changing the Gecko.Events.GeckoDocumentCompletedEventArgs to the IE equivalent. I may not do this tonight as it's late, though.

Currently, closing tabs is not yet implemented.

I've taken a look at the tab class and it looks nice, though my browser is licensed under GPLv3 and I'm not sure if I can mix it with controls/code under the MIT license or how to do it if possible. I've looked into mixing licenses and haven't found anything concrete yet. Do I just add the tab class file to my project and build then use it?

I've actually been thinking about using GeckoFX but last I tried to use it (and now), it was still at version 45 while Firefox is at version 54 already. Although I guess it doesn't matter that much as I'm using IE, which is generally worse than most other browsers.

A lot of my GitHub issues I've made are just things I've thought about and wanted to write down so I didn't forget them.

Even while making the new tab class I knew it wasn't the best, but didn't really know anything better. Especially while using all those Tags. The reason why it's in another class is just to separate stuff as much as possible.

For now I just want a good add/remove tab system, and later add the close button, page favicon, and document title. Probably document text sooner than close button, followed by page favicon. I'm pretty sure using Tags is a bad way to manage browsers in different tabs. In fact, I noticed you're using a CType to access the browser which probably helps with resources. I changed the way I access my browsers in each tab to CType for at least the Reload button.

I'll have to list you as a contributor at least in the About window (when I switch to the one from my launcher which I want to do soon hopefully,) and the Wiki with a link to the Contributors wiki page from the Readme, if that's ok with you.

Again, thank you for your help.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DrewNaylor/DrewWebBrowser/issues/14#issuecomment-313592461, or mute the thread https://github.com/notifications/unsubscribe-auth/AMphBoV_X-A--xJ4lzuXHOevwGBUfpAkks5sLcXkgaJpZM4OQB__ .

[jdc20181]

lol, I thought I changed the events to Webbrowser before I made the pull request all well.