DrewNaylor / UXL-Launcher

An app launcher meant to launch Microsoft Office 2010, 2013, 2016, 2019 desktop software/apps, including ones from Office 365. Not associated with Microsoft.
Apache License 2.0
7 stars 1 forks source link

The theme engine error handler debug output isn't used for Exceptions in the code that pulls colors from XML. #143

Closed DrewNaylor closed 5 years ago

DrewNaylor commented 5 years ago

This needs to be used there, but not right now as it's late at night.

DrewNaylor commented 5 years ago

Basically this part where the Exception is caught:

#Region "Button BackColor"
        ' Only pull the Button BackColor element from XML if it exists.
        If themeSheet.SelectSingleNode("/UXL_Launcher_Theme/Theme_Colors/Button/BackColor[1]", themeNamespaceManager) IsNot Nothing Then
            Try
                colorButtonBackColor = ColorTranslator.FromHtml(themeSheet.SelectSingleNode("/UXL_Launcher_Theme/Theme_Colors/Button/BackColor[1]", themeNamespaceManager).InnerText)
                debugmodeStuff.updateDebugLabels()
                ' If the element isn't a valid HTML color, just replace it with the default.
            Catch ex As Exception
                colorButtonBackColor = Color.Transparent
            End Try
        Else
            ' If the element doesn't exist, overwrite it with the Default theme's value.
            colorButtonBackColor = Color.Transparent
        End If
#End Region
DrewNaylor commented 5 years ago

Actually, is this really that important to have it go into the debug output?

DrewNaylor commented 4 years ago

Guess this isn't going on the changelog.