DrewNaylor / guinget

Unofficial GUI for Microsoft's Windows Package Manager (winget). Kinda like Synaptic, but for Windows. Not associated with either Microsoft or the Synaptic project, and Microsoft does not endorse this software.
Apache License 2.0
136 stars 3 forks source link

Remove update-manifests.bat and direct manifest loading support. #116

Closed DrewNaylor closed 3 years ago

DrewNaylor commented 3 years ago

Support for both update-manifests.bat and direct manifest loading have finally been removed with this PR. I kept the update-manifests.bat file around but moved it to the deprecated folder just in case people wanted to use it as a base for another script or just wanted to see what it was. Additional changes include a region being fixed and the 7-Zip and RoboCopy cache update code being changed to use Async Task.Run so that the progress bar continues to move and both the main window and the progress window remain interactive. Both the 7-Zip and RoboCopy code now also use Using instead of Dim, which should improve memory usage but I don't know for sure if it will.

What's really interesting about this is that these changes amount to a net file size decrease of 11 KB in guinget.exe and libguinget.dll, though 8 KB is from not including update-manifests.bat in the Debug folder. The actual net file size decrease when only counting files that still exist would therefore be only 3 KB, which is still nice. guinget.exe itself is 5 KB smaller, though libguinget.dll ended up becoming slightly larger (was 45.5 KB and is now 47.5 KB) for some reason. This may be due to adding the async code to the 7-Zip and RoboCopy code.

Closes #115.