Drewpeifer / medialytics

A basic, free tool that shows information about Plex Media Server content
GNU General Public License v3.0
112 stars 9 forks source link

2.1 Updates and Docker publishing #7

Closed Drewpeifer closed 11 months ago

Drewpeifer commented 11 months ago

Contributions

General

Bugs Fixed

New Features

Drewpeifer commented 11 months ago

@jzucker2 whenever you have a few minutes to a look, this is very close to your PR I believe but I tried to set it up myself so that I understood what was going on a little better. Please feel free to let me know if you see any issues, it looks like the action was successful though and i see the container at ghcr.io/drewpeifer/medialytics:pr-7. Thanks again!

jzucker2 commented 11 months ago

Sounds good! I should be able to check it out today

jzucker2 commented 11 months ago

Also, last piece, once you start supporting Docker images in a container registry, you should probably try to be holistic about tagging/versioning because people tend to rely on that for Docker.

And we can try to add it to DockerHub too if you'd like, though I'd recommend doing that in a separate PR.

FYI the dependabot will open up PRs against your repo for updates to GitHub actions too. I believe my files are a version behind, we would see this on merge. I can also help you fix it too. We can adjust all of this.

Drewpeifer commented 11 months ago

@jzucker2 All of that makes sense to me, thanks for taking a look offering to edit! Please feel free to commit any changes directly against develop branch and they'll update on this PR. Whenever you're comfortable with the docker changes, you can comment or approve this PR, and I'll squash+merge after I review later (i might push a few small UI fixes this evening too).

For versioning, I'd like to be more consistent so any suggestions/edits there are welcome. There is a draft release for tag=v2.1 created.

jzucker2 commented 11 months ago

@jzucker2 All of that makes sense to me, thanks for taking a look offering to edit! Please feel free to commit any changes directly against develop branch and they'll update on this PR. Whenever you're comfortable with the docker changes, you can comment or approve this PR, and I'll squash+merge after I review later (i might push a few small UI fixes this evening too).

For versioning, I'd like to be more consistent so any suggestions/edits there are welcome. There is a draft release for tag=v2.1 created.

Pushed up a commit to follow up on my suggestions!

So usually semantic versioning is more like v2.0.0 and this could be v2.1.0 but that can also work. There's just no tag history prior to the first docker image, so going forward, we should make sure to create a tag for any big merges to master, basically, so that there can corresponding docker images.

Thanks so much for all the work on this project! I think it's really cool and I'm glad to have it running at my place.