search

Drewsif / PiShrink

Make your pi images smaller!
MIT License
3.51k stars 645 forks source link

PiShrink does not ummount or release mounted image after shrink? #223

Closed Jibun-no-Kage closed 1 month ago

Jibun-no-Kage commented 2 years ago

PiShrink does not ummount or release mounted image after shrink?

/shrink# mount | grep rootfs

/shrink/2021-12-22 Pi3ModelB0 (Real Time Clock Source Example).img on /media/root/rootfs type ext4 (rw,nosuid,nodev,relatime,errors=remount-ro,uhelper=udisks2)

Should PiShrink not release the mounted image?

Drewsif commented 2 years ago

It should unmount the image once it is done with the shrink. Did PiShrink finish successfully?

Jibun-no-Kage commented 2 years ago

Right, it is when there is an error or unsuccessful result, the mount point remains. So whatever clean up should be working, seems to fail at least some of the time. Since efsck tends to choke on non linux partition, i.e. boot being vfat, that is on such trigger for the abort and no clean up, based on my experience thus far.

Drewsif commented 2 years ago

Ahh that makes sense. Ill leave this open to remember to look into making sure we clean up better

Jibun-no-Kage commented 2 years ago

Cool. That is what I was looking for. Thanks.

Drewsif commented 1 month ago

Checked it again and it should be good