search

DrexHD / MagicParticles

A server side cosmetics mod, that allows administrator to create custom particles using simple json files
MIT License
2 stars 2 forks source link

1.20.1 Crash #5

Open VOrlando520 opened 4 days ago

VOrlando520 commented 4 days ago

Crashed the server randomly with the following crash report https://pastebin.com/hfWxcA6P

DrexHD commented 3 days ago

That's a weird crash. Iterating the player list on the server thread should not cause any issues in a regular environment. Can you sent a list of your mods and if possible how to reproduce this (did someone leave / join / change world just before the crash)

VOrlando520 commented 3 days ago

Probably an optimization mod then from my guess. Idk if there is a command on Fabric to output the list of mods on a server, but it was a very random crash that is hard to pinpoint with 50-60 people on a server all doing random things.

DrexHD commented 3 days ago

Can you sent the full crash log (it has the mod list included and some additional information that might help pinpoint the problem). You can send it to me in DMs via discord (my support discord is linked in my profile) if you don't want to leak anything here (like player names + locations and mod list)

VOrlando520 commented 1 day ago

Can you sent the full crash log (it has the mod list included and some additional information that might help pinpoint the problem). You can send it to me in DMs via discord (my support discord is linked in my profile) if you don't want to leak anything here (like player names + locations and mod list)

https://pastebin.com/LGjh2a2i

DrexHD commented 1 day ago

I don't see any horribly bad mods in that list at a quick glance. I was however hoping for the A detailed walkthrough of the error, its code path and all known details is as follows: section, because I want to check if any other thread stack trace could be hinting at something modifying the player list.

VOrlando520 commented 1 day ago

I don't see any horribly bad mods in that list at a quick glance. I was however hoping for the A detailed walkthrough of the error, its code path and all known details is as follows: section, because I want to check if any other thread stack trace could be hinting at something modifying the player list.

Ah, was hoping you'd of seen something I didnt. Sadly I had gotten this crash 3 more times and had to disable it until we can find the underlying cause. That was the full crash report though. Since it has been disabled no crashes though. So im lost :\

DrexHD commented 1 day ago

Looks like the Thread Dump I was looking for is only added to the crash report when the crash is caused by Server Watchdog. I don't think I can do anything about this crash at the moment unfortunately. I would need some way to (at least somewhat) consistently reproduce the issue to start debugging it! With such a big mod list and it presumably only happening very rarely and no further info I don't really have a chance :/

VOrlando520 commented 1 day ago

Looks like the Thread Dump I was looking for is only added to the crash report when the crash is caused by Server Watchdog. I don't think I can do anything about this crash at the moment unfortunately. I would need some way to (at least somewhat) consistently reproduce the issue to start debugging it! With such a big mod list and it presumably only happening very rarely and no further info I don't really have a chance :/

Im going to flip server watchdog back on and reenable this for my next restart, see if i can get this to happen again for a more detailed stacktrace for ya

DrexHD commented 1 day ago

Please try it with the referenced commit, it should prevent the crashes and create a crash report (without shutting down) with the desired information instead. I am skeptical it will actually reveal the cause, but it is my best shot and should at least prevent the crashes for you! If you use this version you should be able to find a crash report with magic-particles in the name (if the issue occurs again) that you should share here!

VOrlando520 commented 1 day ago

Please try it with the referenced commit, it should prevent the crashes and create a crash report (without shutting down) with the desired information instead. I am skeptical it will actually reveal the cause, but it is my best shot and should at least prevent the crashes for you! If you use this version you should be able to find a crash report with magic-particles in the name (if the issue occurs again) that you should share here!

Will report back with my findings when it happens!

VOrlando520 commented 23 hours ago

Please try it with the referenced commit, it should prevent the crashes and create a crash report (without shutting down) with the desired information instead. I am skeptical it will actually reveal the cause, but it is my best shot and should at least prevent the crashes for you! If you use this version you should be able to find a crash report with magic-particles in the name (if the issue occurs again) that you should share here!

crash-2024-07-02_02.01.23-magic-particles.txt unsure if that will help you but here ya go

DrexHD commented 10 hours ago

Unfortunately that didn't help :/

DrexHD commented 10 hours ago

Whoops didn't meant to close and send that. Unfortunately that didn't help :/ I am not really sure how else I could investigate this (and also why this doesn't happen with any other mod). By the way you seem to have some mod spam creating tons of Timer threads, which definitely isn't great (and could be related :shrug:).