Drexel-UHC / SALURBAL-Heat-Study-MS85

URL: https://drexel-uhc.shinyapps.io/MS85/
4 stars 1 forks source link

Adding two metrics: RR at P95 and P5 #12

Closed jlkephart closed 1 year ago

jlkephart commented 2 years ago

Hi Ran - as per editors we need to add the RR at P95 and P5 as metrics throughout the app. The priority is first under the "City-specific Details" tab, then the rest of the app.

I added the two variables to the original dataset of mortality results for the app: https://drexel0-my.sharepoint.com/:x:/g/personal/jlk465_drexel_edu/Ea_EnXL6vGNIksmIPTMNemsBJrWSCI-rAlPs4JaQb7OcLA?e=RBXbs1

The variables we need to add

Relative risk at 5th percentile: [RR_at_P5]

Relative risk at 95th percentile: [RR_at_P95]

I'm back and around on slack for any Q's. Thank you!!

ran-codes commented 2 years ago

Got it! I will start working on this.

You mentioned it was time-sensitive right?

ran-codes commented 2 years ago

Updates

@jlkephart Let me know what you think before we move it to the public-facing URL!

jlkephart commented 2 years ago

Ran this is fantastic. I owe you one, thanks so much for such a quick response!

Publish!

On Tue, May 3, 2022 at 12:44 PM Ran Li @.***> wrote:

Updates

@jlkephart https://github.com/jlkephart Let me know what you think before we move it to the public-facing URL!

— Reply to this email directly, view it on GitHub https://github.com/Drexel-UHC/SALURBAL-Heat-Study-MS85/issues/12#issuecomment-1116318243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5DGKFC4Y77HJOOWEUTBODVIFJXNANCNFSM5U375A5A . You are receiving this because you were mentioned.Message ID: @.***>

ran-codes commented 2 years ago

Your welcome 😄

published! feel free to close this issue when you've checked!

jlkephart commented 2 years ago

Hi Ran, sorry noticed one thing. Could you please log-transform the X-axes for the four relative risk metrics in these two tabs:

Effects of Temperature -> By Climate Zone Effects of Temperature -> By Country

ran-codes commented 2 years ago

no problem! its been updated 😄

jlkephart commented 1 year ago

Yes, hoping to resubmit asap. If we even have only one tab done we can submit and say "the metric is there", then keep working on the rest of it.

Thanks Ran, I appreciate it!

On Mon, May 2, 2022 at 2:24 PM Ran Li @.***> wrote:

Got it! I will start working on this.

You mentioned it was time-sensitive right?

— Reply to this email directly, view it on GitHub https://github.com/Drexel-UHC/SALURBAL-Heat-Study-MS85/issues/12#issuecomment-1115219196, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5DGKEPEHJZJLKWZKOGOWLVIAMWXANCNFSM5U375A5A . You are receiving this because you authored the thread.Message ID: @.***>

ran-codes commented 1 year ago

is there something that needs updating? I thought the RR at P95 and P5 was done?

ran-codes commented 1 year ago

closing because email or GH problem reopened this issue. who knkows.

👻 👻 👻 👻