Drexel-UHC / SALURBAL-Heat-Study-MS85

URL: https://drexel-uhc.shinyapps.io/MS85/
4 stars 2 forks source link

PN1 Review #5

Closed ran-codes closed 2 years ago

ran-codes commented 2 years ago

@jlkephart @usamabilal

Prototype number 1 (PN1) is ready for review: https://drexel-uhc.shinyapps.io/MS85/

Feedback please

PN1 should have most of the features you requested but still needs polishing (please see the next section of things I know need fixing). Let me know what you think about it so far and provide feedback:

Things to polishing in PN2

jlkephart commented 2 years ago

This is great! Issues I can see:

Hover text box over map points: -Remove SALID1, and any other visible references to SALID1 throughout the app -Round Mean Temp to one decimal place throughout the app

Age Group: -Replace "crude" with "all-ages" -Default to all-ages

Change "RR of heat-related mortality" to "Mortality risk per 1C higher extreme heat" Change "RR of heat-related mortality" to "Mortality risk per 1C lower extreme cold"

City-specific Tab: Add ability to select cities via clicking on map

Major issue: Add maps of excess death fraction (EDF, confusingly called "AF" in the dataset) for all heat and all cold, as additional Metrics (all cold, extreme cold, all heat, extreme heat). This can also be the primary bivariate comparison with RR, instead of mean temp. So, RR of heat vs. EDF for extreme heat and same for cold

jlkephart commented 2 years ago

Forgot to say sorry about the EDF - I missed that before!

usamabilal commented 2 years ago

(and please, feel free to ignore my suggestions/feedback! I"m just some external reviewer here :-P; @jlkephart your call! )

jlkephart commented 2 years ago

@usama,

1) eventually these will be 5 discrete color categories, with the lowest cat being [<= 1], so we can anchor the coloring at 1 and diverge the color in one direction only (upwards) .

2) Agreed

3) love this idea, not the immediate priority but would be great if we can incorporate in the future

ran-codes commented 2 years ago

Thanks for the feedback everyone. Everything seems rational and feasible = ). I have compiled the feedback as a tasklist in #7.

eventually these will be 5 discrete color categories, with the lowest cat being [<= 1], so we can anchor the coloring at 1 and diverge the color in one direction only (upwards) .

@jlkephart quick q about this: can you supply the hex codes for this divergent pallete?

jlkephart commented 2 years ago

These are the colors used in Figure 3 in the manuscript, 5 classes, viridis: plasma

"#F0F921FF" "#F89441FF" "#CC4678FF" "#7E03A8FF" "#0D0887FF"

ran-codes commented 2 years ago

thanks josiah!! 😄