search

Dri0m / flashpoint-submission-system

Submission management system created specifically to deprecate BlueMaxima
MIT License
8 stars 4 forks source link

Verifiers can't approve their RCs without Unassigning and Reassigning first #58

Open Dukktape opened 3 years ago

Dukktape commented 3 years ago

Not sure if this is intended or just a necessary evil, but if you are Assigned for Verification and you RC the submission, you can't approve without Unassigning yourself from Verification and Assigning yourself to Testing. Ideally, Verifiers should be able to approve without having to do this first. Currently, the only options available to Verifiers who RC are Comment, Unassign from Verifying, RC, and Reject.

If it's possible for the green Approve button to appear for Verifiers after they RC, that would be good. Automatically changing them to Testers after they RC would work to. I don't know if either of these is possible/feasible though.

If fixing this isn't possible, could it at least be noted somewhere, because I've seen people get confused by it.

Dri0m commented 2 years ago

verify and approve are a different thing, please clarify, why would a verifier need to approve? that's not how the workflow should work according to the flowchart

Dukktape commented 2 years ago

If a Verifier needs to Request Changes, they can't verify. They have to approve since RCing clears the previous approval. The game needs to be reapproved with the changes and since the Verifier is the only one that can clear their own RCs they need to be the one to do it.

Dukktape commented 2 years ago

And this is correct in how it works according to the flowchart. When something is RC'd it returns to the beginning of the process. The problem is that the staff member RCing isn't being moved back with it, if that makes sense. They have to do this workaround of unassigning and reassigning in order to be in the correct state with the submission.