search

DriHut / ReFramed

A Framed Block fabric port based on the Template 2 mod
Other
8 stars 1 forks source link

Lighter frames showing up as invisible? #4

Closed Dumpling00 closed 7 months ago

Dumpling00 commented 7 months ago

Hello! Big fan of your mod here. I'm having this peculiar issue when placing the clear looking frames. I'm on Fabric 1.20.4. Could this be looked into?

https://github.com/DriHut/ReFramed/assets/44829013/4ca15e2c-cd06-4efb-a3e2-d3b9ab09593f

Thanks for your time!

DriHut commented 7 months ago

From what I see you are using iris with it. It could be iris or it could be another mod so if you can give me a list of the mods you have or try removing some mods till you find the one that is problematic. Then I can maybe figure out a fix for it ^^.

Dumpling00 commented 7 months ago

From what I see you are using iris with it. It could be iris or it could be another mod so if you can give me a list of the mods you have or try removing some mods till you find the one that is problematic. Then I can maybe figure out a fix for it ^^.

Hi! Unfortunately I have at least a hundred other mods so it's gonna be a bit tricky to find the culprit haha. Would you know which kind of mod could be the cause of this? Anything that touches graphical rendering I'm guessing?

DriHut commented 7 months ago

Yes any mod that add rendering so that's why I mentioned iris. Maybe if you add a list of the mods I can already cross out the ones that shouldn't be causing this issue.

Dumpling00 commented 7 months ago

Yes any mod that add rendering so that's why I mentioned iris. Maybe if you add a list of the mods I can already cross out the ones that shouldn't be causing this issue.

Okay I just checked and I have 311 mods installed, so a bit more than 100 lol. But here, I've tried with a new instance (basically unmodded) and everything looks great. (Fabric 1.20.4 btw)

Added Iris, and this happens: image

Added Indium on top, and we're back to this image

Added Entity Culling, Continuity, Fusion (Connected Textures) and Ferrite Core - No changes Tried with Shaders on - No changes

And now I had a thought - could it be the texture packs? Turns out, these are the issue: image

How it looks with xali's texture pack only: image

How it looks with Glass Pane Culling Fix only: image

How it looks with all three together: image

Issue persists when disabling the resource packs. image

Various degrees of results depending on the order, it seems.

Hope this helps! Thank you in advance for your time!

DriHut commented 7 months ago

Ooooh now I might know why it does this 😅. I'm pretty sure that if you reload the game when you add the texture pack this will work as in it might be due to the remapping of the atlas but since I keep those in cache it still tries to take the texture at the same place on the atlas hence why it looks like this. So I don't think that's why it wasn't working in the first place but that is an issue I need to fix too 😅.

Also thank you for taking the time to figure out what is wrong 🙏.

DriHut commented 7 months ago

image image

I just tried it and it seems to be exactly what I though the fixt will be quite easy to implement. (for context I used the top block as a theme first then loaded the texture pack then used the second block) so when I remove the texture pack the top is good and bottom wrong ^^.

Dumpling00 commented 7 months ago

Awesome to hear! Can't wait to test out the new version. Thank you for your efforts :)

DriHut commented 7 months ago

Yeah well I still think the first error you showed wasn't due to this...

Dumpling00 commented 7 months ago

Yeah well I still think the first error you showed wasn't due to this...

Seems like that can be fixed by simply listing indium as another dependency for iris users though! Albeit being not exactly a dependency, it does seem to counter the issue.

DriHut commented 7 months ago

oh so you weren't using indium at the beginning ? cuz if yes then its normal that it breaks as the mod needs indium if there is sodium installed and iris uses sodium.

Dumpling00 commented 7 months ago

I can also confirm that this issue is indeed caused by Continuity's Default Connected Textures.

image

Applying a cube to frames that are rendered invisible because of this causes the void to appear. Doesn't happen with Glass Pane Culling Fix enabled on its own.

Dumpling00 commented 7 months ago

oh so you weren't using indium at the beginning ? cuz if yes then its normal that it breaks as the mod needs indium if there is sodium installed and iris uses sodium.

Nope! The first image with the null blocks happens with Iris/Sodium only. Adding Indium fixes the issue.

DriHut commented 7 months ago

I can also confirm that this issue is indeed caused by Continuity's Default Connected Textures. ...

Yeah that sounds pretty likely continuity probably inject in the rendering of their textures before my code is injected hence why it breaks with it. Though I might add full support for Continuity anyway. Also the side is invisible probably because it still computes the cull even though its not being rendered.

DriHut commented 7 months ago

Nope! The first image with the null blocks happens with Iris/Sodium only. Adding Indium fixes the issue.

Ok nice that this was the issue ^^. (less for me to fix ;-) ) Please make sure you always use indium when you have sodium installed.

Dumpling00 commented 7 months ago

I can also confirm that this issue is indeed caused by Continuity's Default Connected Textures. ...

Yeah that sounds pretty likely continuity probably inject in the rendering of their textures before my code is injected hence why it breaks with it. Though I might add full support for Continuity anyway. Also the side is invisible probably because it still computes the cull even though its not being rendered.

Yeah I've encountered similar issues before so I figured! It was a fun hunt though, glad I could help. Good luck with your endeavors!

DriHut commented 7 months ago

Thanks for the feedback always appreciated ^^