search

Drieam / rspec-github

Formatter for RSpec to show errors in GitHub action annotations
https://drieam.github.io/rspec-github/
MIT License
60 stars 10 forks source link

ci: Replace reviewdog with plain Rubocop #22

Closed nschonni closed 6 months ago

nschonni commented 1 year ago

Swap reviewdog with a plain Rubocop call, along with a problemmatcher to show issues on the PR files tab

nschonni commented 1 year ago

Had to add the second commit to quote the ruby version numbers, as I remembered with the first failure https://github.com/nschonni/rspec-github/actions/runs/4388566499/jobs/7685202341 that GitHub/Yaml does a weird thing with the trailing 0 in the numbers like 3.0. They get parsed down to 3, which gets interpreted as 3.2 as the latest 3.x release. Now passing with minimal changes https://github.com/nschonni/rspec-github/actions/runs/4390033688/jobs/7688162990

StefSchenkelaars commented 1 year ago

@LuukvH Can you maybe update the merge settings?

nschonni commented 1 year ago

@LuukvH are you interested in this one, or should I close it?

LuukvH commented 1 year ago

@nschonni I don't know this action, and I'am not sure what it does. Just wanted to checkout that repo first (support / code etc) before deciding to merge it. At the moment the Github token has both read and write permissions to the repo. I was thinking about explicit adding the permissions to the Workflows as a safety measure. What do you think?

nschonni commented 1 year ago

It shouldn't need any permissions I believe, as this is the native version of the problem matcher. It's really just this JSON file for the regex https://github.com/r7kamura/rubocop-problem-matchers-action/blob/main/.github/matchers/rubocop.json and an echo statement to register the JSON file with the GitHub Action runner https://github.com/r7kamura/rubocop-problem-matchers-action/blob/main/index.js

This was actually the simpler approach I was looking for when I originally found your project 😆