Drieam / rspec-github

Formatter for RSpec to show errors in GitHub action annotations
https://drieam.github.io/rspec-github/
MIT License
61 stars 10 forks source link

Env var to disable pending specs annotations #3

Closed duderman closed 4 years ago

StefSchenkelaars commented 4 years ago

Hi @duderman, thanks for your PR! Sorry it took me some time, I just didn't notice this PR at all. So next time, feel free to mention me 👍

But we actually experienced the same issue ourselves as well but this behaviour is also provided by RSpec itself. If you add the --tag ~skip to your RSpec command, it will just skip the pending test (and thus not show them in your GitHub Actions result).

Will that also work for you?

duderman commented 4 years ago

Hi @StefSchenkelaars ,

You are right. Completely forgot about RSpec option. Which I think is much better as it's native for the framework. Closing this PR then. Thanks!

StefSchenkelaars commented 4 years ago

@duderman But please feel free to add some information about this to the readme and help others with similar problems :)