search

Drillgon200 / Hbm-s-Nuclear-Tech-GIT

My fork of the HBM's nuclear tech mod.
46 stars 19 forks source link

[Issue] Incompatibility with Pollution of the Realms' Pollution Blocks and NTM's Missiles #164

Open gatoborrachon opened 2 years ago

gatoborrachon commented 2 years ago

What is happening When you launch a NTM Rocket and it goes through some Pollution of the Realms' Pollution Blocks, it will explode instead of ignore them

Steps to reproduce

  1. Place some Pollution Blocks (in the example below i used Sulfur) on a specific area
  2. Setup a rocket launch base and make it go through these Pollution Blocks
  3. See it explode

Screenshots 2021-10-26_10 19 39 2021-10-26_10 19 43 2021-10-26_10 19 44

Versions NTM: hbm-1.6.4a-Gv1 Pollution of the Realms: 1.12.2-1.2.21.1-build.0617 ForgeEndertech: 1.12.2-4.5.5.0-build.0561 (Library of Pollution of the Realms)

Additional Notes Well, there was a similar issue with the cars from Immersive Vehicles where they interact with these Pollution Blocks, but the Author of Pollution of the Realms told him how to fix it and it worked, so i just wanted to tell you about this, to not let issues forgotten

In short, the fix only requires to add this check: state.getCollisionBoundingBox(world, pos) != null On lines like this one: https://github.com/Drillgon200/Hbm-s-Nuclear-Tech-GIT/blob/master/com/hbm/entity/missile/EntityMissileBase.java#L228

Drillgon200 commented 2 years ago

Didn't this one already get reported? That's not how I would fix it anyway; the missiles should be doing a real ray trace, not a crappy block check that allows it to skip through blocks.

gatoborrachon commented 2 years ago

well, yeah it was reported in the Discord server, but as you said one time there, it is easier for the dev to fix issues that are well documented and listed in the Github's Issues Section (for formality and readability)

And yeah, you also said that the missiles should do a raytrace, bad from my part, i forgot it but i also wanted to list here what the author of the other mod said. (and a reason why i added that just as an additional note, low importance)