search

Drillster / drone-email

Drone plugin for sending email notifications
Apache License 2.0
45 stars 43 forks source link

Update Dockerfile for arm architecture #39

Closed xemle closed 3 years ago

mjwwit commented 3 years ago

I'm not sure how I missed this PR, I'm terribly sorry about that... I'm not too familiar with ARM images for Docker, would you mind explaining how your proposed changes work? It looks like you removed all ARM specific parts, except for an environment variable. How will Docker know to build an ARM image?

xemle commented 3 years ago

No worries.

I just saw that the Dockerfile was updated and Dockerfile.armhf wasn't. The updated Dockerfile.armhf file is a updated version of Dockerfile and works on my Raspberry PI using raspbian with drone runner and your plugin.

I am not deep in the topic, but since the updated Dockerfile.armhf builds the golang plugin binary for arm architecture it should be fine. So I published the arm docker image to https://hub.docker.com/r/sfelis/drone-email for my CI environment from raspbian through a drone task.

mjwwit commented 3 years ago

Alright, that sounds good enough! Thanks!