allow disabling starttls

Drillster / drone-email

Drone plugin for sending email notifications

Apache License 2.0

44 stars 43 forks source link

allow disabling starttls #57

Closed glaszig closed 2 years ago

glaszig commented 2 years ago

use more up-to-date gomail fork
add starttls option

mjwwit commented 2 years ago

I've had to change the implementation in your PR as it was disabling StartTLS by default. The flag has now been changed to no_starttls which you have to explicitly set to true in order to disable StartTLS, fixing the default behavior.

glaszig commented 2 years ago

oh shoot. you're right. i was trying to set a default of "true" but the cli package doesn't offer that on BoolFlag so i eventually missed that -.-