search

Drillster / drone-email

Drone plugin for sending email notifications
Apache License 2.0
46 stars 43 forks source link

TLS is disabled by default #58

Closed elundblad closed 3 years ago

elundblad commented 3 years ago

Hello,

I've noticed what seems a change in behavior as of this PR, that now requires starttls: true to be explicitly set to true to enable TLS.

I noticed my email sending using AWS SES no longer works in my drone builds with error

time="2021-11-01T07:15:45Z" level=error msg="Error while dialing SMTP server: unencrypted connection"

However explicitly setting starttls: true works, but from how I understand the PR above it should be enabled by default

Thank you

mjwwit commented 3 years ago

It should default to true, yes. I thought I tested this as well... I will have a look at this later today.

mjwwit commented 3 years ago

I failed to notice that my testing mail server just accepted whatever starttls setting I gave it... Either way, I fixed the issue by flipping the starttls flag. It's now called no_starttls which you have to explicitly set to true to disable StartTLS.