search

Drillster / drone-volume-cache

Drone plugin for caching to a locally mounted volume
MIT License
109 stars 42 forks source link

change cache to operate on a branch-by-branch basis #16

Closed Rush closed 6 years ago

Rush commented 6 years ago

I think this is a much better default behavior. Less cache misses when people are working on multiple different branches and each can thrash the cache.

Let me know if you think this needs to be configurable

mjwwit commented 6 years ago

I know the current behavior is less than optimal, but I've actually been thinking of doing something in the lines of https://github.com/Drillster/drone-volume-cache/issues/12#issuecomment-325314080.

I'm not a fan of changing the default, since it will cause every cache to be invalidated.

Rush commented 6 years ago

Thanks. I'll give it some thought but probably the cache key template should allow for any env vars rather than just what we can come up with.

mjwwit commented 6 years ago

That would be a very nice addition indeed.

mjwwit commented 6 years ago

I finally found the time to implement configurable cache keys (in https://github.com/Drillster/drone-volume-cache/commit/464e3f02892f84f644596e6a0d1a35c0e1df2bb5).