version 1.49 unbuildable on linux

[wdoekes]

Many issues with 1.49. Was this release intentional?

• 1.49 is a lot higher than 1.20.0
• 1.49 does not have a 1.49.0 patch version
• #define LOGX is done twice
• OPAL_DiskInfo is now DTA_DEVICE_INFO
• void DtaDevOS::identify should be bool ...

[RossiSoftLtd]

Just found out the same issue. Wondering the same as @wdoekes

Thanks

[cranderson]

g++ -DHAVE_CONFIG_H -I. -Wall -Werror -std=c++11 -I./linux -I./Common -I./Common/pbkdf2 -I./linux -I./LinuxPBA -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -c -o LinuxPBA/UnlockSEDs.o LinuxPBA/UnlockSEDs.cpp make[1]: Leaving directory '/builddir/build/BUILD/sedutil-1.49' In file included from ./linux/os.h:28, from LinuxPBA/UnlockSEDs.cpp:20: ./Common/log.h:338:9: error: "LOGX" redefined [-Werror] 338 | #define LOGX(level) \ | ^~~~ ./Common/log.h:330:9: note: this is the location of the previous definition 330 | #define LOGX(level) \ | ^~~~ In file included from LinuxPBA/UnlockSEDs.cpp:22: ./linux/DtaDevOS.h:58:19: error: ‘OPAL_DiskInfo’ has not been declared 58 | void identify(OPAL_DiskInfo& disk_info); | ^~~~~ ./linux/DtaDevOS.h:60:24: error: conflicting return type specified for ‘virtual long long unsigned int DtaDevOS::getSize()’ 60 | unsigned long long getSize(); | ^~~ In file included from ./linux/DtaDevOS.h:21: ./Common/DtaDev.h:134:36: note: overridden function is ‘virtual const long long unsigned int DtaDev::getSize()’ 134 | virtual const unsigned long long getSize() = 0; | ^~~ LinuxPBA/UnlockSEDs.cpp: In function ‘uint8_t UnlockSEDs(char*)’: LinuxPBA/UnlockSEDs.cpp:34:39: error: ‘getDtaDevOS’ is not a member of ‘DtaDevOS’ 34 | if (DTAERROR_SUCCESS == DtaDevOS::getDtaDevOS(devref, &d, true) && d!=NULL) { | ^~~ cc1plus: all warnings being treated as errors make[1]: *** [Makefile:782: LinuxPBA/UnlockSEDs.o] Error 1