search

Drive4ik / simple-tab-groups

Create, modify and quick change tab groups. Inspired by the Tab Groups app :)
https://addons.mozilla.org/firefox/addon/simple-tab-groups/
Mozilla Public License 2.0
1.15k stars 91 forks source link

In a group with "always open tabs in container" set, new tabs are duplicated if a different extension redirects the URL #1101

Open oddmechanism opened 11 months ago

oddmechanism commented 11 months ago

Describe the bug When opening a new tab to a URL that gets redirected by another extension, two tabs are opened to the destination site. This can happen after opening a new tab and typing or searching with the address bar, or opening a bookmark in a new tab. I've had this happen with ClearURLs, Old Reddit Redirect, and LibRedirect. #740 and #857 report a similar issue but I believe this is the root cause, as I can't reproduce it with no extensions other than Simple Tab Groups. The behavior is not consistent; the bug sometimes doesn't happen and the browser opens just one tab like expected, and I haven't been able to pin down the reason for this, but reopening the browser seems to put things in a state where it always happens. ClearURLs seems to sometimes cause the bug when searching with Google, but this is even less consistent and I haven't found a way to reliably reproduce it.

To Reproduce Steps to reproduce the behavior:

  1. Install Simple Tab Groups and Old Reddit Redirect (https://addons.mozilla.org/en-US/firefox/addon/old-reddit-redirect/)
  2. Completely close and reopen Firefox.
  3. Create a new group.
  4. In the group settings, set "always open tabs in container" to Personal
  5. Click the + in the tab bar to open a new tab.
  6. Type reddit.com in the address bar and hit Enter.
  7. Two old.reddit.com tabs are opened.

Expected behavior One old.reddit.com tab is opened.

Screenshots Before: image After: image What should happen: image

Desktop (please complete the following information):

Additional context The bug does not not occur when navigating to a redirected site while already in a container tab. It specifically happens when a new tab is opened

achernyakevich-sc commented 11 months ago

@oddmechanism Have you installed Multi-Account Container add-on?

If an answer is yes then probably it could be misconfiguration of that add-on (no of Simple Tab Groups add-on). This comment in MAC repository about possible reconfiguration could potentially help you. If it works for you, could you close this issue as it is not a bug but more like misconfiguration. :)

oddmechanism commented 11 months ago

@achernyakevich-sc The bug happens regardless of whether or not Multi-Account Containers is installed or whether or not that checkbox is enabled.

lasnikr commented 9 months ago

I have the same problem just with DuckDuckGo, it also only occurs when creating a tab with STRG + T. When using multi-account-containers shortcuts or doing it via user interface, it is no problem at all. I also think it has something to do with redirecting because it doesn't happen when I use another search engine than Duck Duck Go or when I disable DuckDuckGo Privacy Essentials Extension.

rLokau commented 7 months ago

I've been suffering the same issue. Based on the comments here, I tested disabling the DuckDuckGo Privacy Essentials extension and the issue stopped, so it definitely seems to be that extension and this not playing nicely together (in my case).

rLokau commented 7 months ago

I think I just found a work-around. In the settings for DuckDuckGo Privacy Essentials, I added duckduckgo.com as a site exception. Now when I search from the address bar in a new tab it works correctly.

glciampaglia commented 1 month ago

I have had the same issue. I just disable the DuckDuckGo Privacy Essentials extension following what @rLokau tried and re-enabled it again and the issue seems to have disappeared.