search

Drive4ik / simple-tab-groups

Create, modify and quick change tab groups. Inspired by the Tab Groups app :)
https://addons.mozilla.org/firefox/addon/simple-tab-groups/
Mozilla Public License 2.0
1.16k stars 91 forks source link

Add support for dark theme #129

Closed Keith94 closed 6 years ago

Keith94 commented 6 years ago

Hi! I noticed the current STG icon doesn't play nice with Firefox's dark theme. Can you add support for automatic color-switching based on current theme? (see: https://github.com/eoger/tabcenter-redux/pull/286 if needed)

firefox_2018-03-23_10-00-07

Drive4ik commented 6 years ago

Hi! You can manualy change this color: screenshot_1

Keith94 commented 6 years ago

Hmm, I don't think it's the best solution because it also affects the popup menu (if you make the icon white, then it's invisible in the menu). Is there a more elegant (automatic) solution?

Drive4ik commented 6 years ago

I understand you, I myself wanted to do so initially, but the fact is that I also need to draw a triangle in this icon with the desired color, so the icon becomes custom, and at this point I must specify the color of the icon itself. since I do not know which theme is now active, I made a setting with a manual color indication. If you know how detect current theme (dark/ligth), please tell me. P.S. https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/theme/getCurrent not working... you can see it: https://github.com/mdn/webextensions-examples/tree/master/theme-integrated-sidebar

Keith94 commented 6 years ago

@Drive4ik Maybe specifying theme_icons in manifest.json could be a solution. You can check these fixes and let me know if that helps you.

Drive4ik commented 6 years ago

Yes, I know about this functional, but as I wrore below "I also need to draw a triangle in this icon with the desired color, so the icon becomes custom", this solution does not fit...

Keith94 commented 6 years ago

@Drive4ik Can you make the "custom icon" optional in the settings? We can choose automatic or custom, so that automatic one will use proper colors in dark theme, etc. but without the triangle.

Drive4ik commented 6 years ago

Hi! I found another way to do this))

Drive4ik commented 6 years ago

Will fix in FF 63 or may be 62

Keith94 commented 6 years ago

Thanks for the fix!

Drive4ik commented 6 years ago

You can try this: https://github.com/Drive4ik/simple-tab-groups/issues/213#issuecomment-406294829 to enable this feature now