search

Driversnote-Dev / react-native-kontaktio

React Native (iOS and Android) library for Kontakt.io beacons (and all other beacons)
MIT License
111 stars 48 forks source link

Remove createJSModules for RN 0.47. #18

Closed exKAZUu closed 7 years ago

exKAZUu commented 7 years ago

Many react-native libraries removes this method (e.g. https://github.com/Microsoft/react-native-code-push/issues/894).

andrekovac commented 7 years ago

Thanks for the PR @exKAZUu ! Will the code still be downards compatible to older RN versions after removing this overriding method?

exKAZUu commented 7 years ago

I think this PR breaks backward compatibility (e.g. RN 0.46 doesn't work on this). Removing only the annotation (@Override) is perhaps able to keep the compatibility. I'll check it!

exKAZUu commented 7 years ago

I found we could keep the backward compatibility via https://github.com/Microsoft/react-native-code-push/pull/895#issuecomment-325700522 and https://github.com/Microsoft/react-native-code-push/pull/980, so I modified my PR.

andrekovac commented 7 years ago

Excellent! Thank you! Could you please also add the comment // Deprecated RN 0.47 as it was done here. Then it is visible to everyone.

After this change I'll accept your PR.

exKAZUu commented 7 years ago

Thank you for your feedback! I modified my PR.

andrekovac commented 7 years ago

Thanks for the fix! I merged it and the new version 2.0.3 contains it.

exKAZUu commented 7 years ago

Thank you for the release! My team will use your library :)