search

Driversnote-Dev / react-native-kontaktio

React Native (iOS and Android) library for Kontakt.io beacons (and all other beacons)
MIT License
112 stars 48 forks source link

iOS Eddystone support #31

Closed jampueroc closed 4 years ago

jampueroc commented 6 years ago

Hi, I added secureProfileListener that come from version 3.3.2 in android

andrekovac commented 6 years ago

Thanks for the great PR! I saw you did not only update the Android SDK, but also updated the iOS SDK and added iOS eddystone methods! Great work! I want to test your code over the easter holidays and then merge. The README and the example app should be updated as well then!

jampueroc commented 6 years ago

Hi, I am really happy that you see my work, this weekend I can help updating documentation :)

Test my fork to check that all works fine before submit another PR

andrekovac commented 6 years ago

I'd like to split this up into two PRs since you're doing very different things here. I cherry-picked the first two commits of this PR, filed PR #36 where I added some stuff.

This PR should be about iOS eddystone support. @jampueroc Could you remove the first two commits (this will also solve the conflicts) or file another PR with the last four commits which are about updating the iOS part? I will then review that separately. Thank you so much for your support!

is343 commented 5 years ago

Is this pull eventually going to go through?

andrekovac commented 5 years ago

@is343 I hoped for @jampueroc to update the documentation about these methods, but there nothing will happen probably. If you'd update the documentation with the new functions, I'd be very happy about the PR!

nicholasc commented 5 years ago

I would love to do the documentation on this. Should I create a separate PR for this? Since @jampueroc is not responding anymore I doubt he would merge my change to his fork in order to update this.

Let me know how you want to achieve this.

andrekovac commented 5 years ago

@nicholasc Excellent! I appreciate it a lot! Yes, please create a second PR for it.

Did you test this branch? Does it work fine for you?

Another thing I want to do is to update the example app. Do you happen to use it? If so, it would be great if you could share your version using these new functions. If not, never mind.

The example app already got quite old now. I might open up a ticket to improve it.

nicholasc commented 5 years ago

I just tested it on iOS and it works fine. I am going to get started writing appropriate documentation for it. I'll keep you posted.