search

Driversnote-Dev / react-native-kontaktio

React Native (iOS and Android) library for Kontakt.io beacons (and all other beacons)
MIT License
112 stars 48 forks source link

Support for RN >= 0.60 and autolinking #67

Closed pkandrashkou closed 4 years ago

pkandrashkou commented 4 years ago

Basically this PR will fix the issue importing iOS code using autolinking. The feature was introduced in 0.60.

Should fixes a bunch of recent issues such as:

https://github.com/Driversnote-Dev/react-native-kontaktio/issues/65 https://github.com/Driversnote-Dev/react-native-kontaktio/issues/64 https://github.com/Driversnote-Dev/react-native-kontaktio/issues/59

This changes are also backwards compatible with everything lower than 0.60.

I think setup.ios.md could be updated in some other way, but I could not decide exactly how, feel free to update / suggest!

Please note that I have not checked how android side works yet. At the moment I cannot just do it, so if somebody can try this PR please also check the android side and let me know 🙂

andrekovac commented 4 years ago

Looks good to me! Thanks for updating it!

jensvansteen commented 4 years ago

Hi the changes of this pull request do not seem to be available via NPM yet. Is it possible to make them available via NPM? @Andruschenko

andrekovac commented 4 years ago

Sorry forgot to do that. npm is at the current level now with version 2.7.1