Fixed a bug and add Store-Zephyrus supported

Drixevel-Archive / Chat-Processor

A Sourcemod plugin which allows other plugins to add and manage chat related features.

GNU General Public License v3.0

58 stars 28 forks source link

Fixed a bug and add Store-Zephyrus supported #16

Closed Kxnrl closed 7 years ago

Kxnrl commented 7 years ago

Fixed only only sender can see the chat , others cant. Add Store-Zephyrus supported.

Drixevel-Archive commented 7 years ago

What's the point of adding a ConVar and a check for the player amount inside of it? I also think that you don't need the stock and using 1 for loop with multiple checks would save lines and make much more sense. Also, why return Plugin_Handled at the bottom?

Drixevel-Archive commented 7 years ago

I just tested your changes and the 'sv_deadtalk' ConVar doesn't exist in TF2. Keep in mind that Chat-Processor isn't a CSGO only plugin so I won't accept this pull request. I have taken some of your changes and have implemented them into the plugin since 'sm_deadtalk' is a consistent ConVar.

Kxnrl commented 7 years ago

i will rewrite later.