search

Drizin / CodegenCS

C# Toolkit for Code Generation (T4 alternative!)
MIT License
223 stars 30 forks source link

Incompatible license in dependency #3

Closed frankhaugen closed 2 years ago

frankhaugen commented 2 years ago

Hi, I'm getting an incompatible license error on my Open Source validation. This is caused by Newtonsoft.Json.Schema -nuget using AGPL-3.0-only -license. You cannot distribute your nuget with MIT because of this.

I'm trying to clean up my licenses situation, (I'm using fossa.com for this), and I'll either have to stop using your library, or you need to update it to be compliant with MIT

Drizin commented 2 years ago

That's a good point. We'd have to migrate to NJsonSchema which is MIT-license. Do you volunteer for this PR? It's a minor change, we're just using Newtonsoft.Json.Schema in a single line, to validate a schema.

frankhaugen commented 2 years ago

@Drizin it was a bit more than a single line but it was ten minutes of work, but see the attached PR, where I have a small snag, (I might just have implemented NJsonSchema incorrectly)

Drizin commented 2 years ago

Thanks for your contribution! I've made some adjustments and added some missing tests (to test that "legacy schema upgrade" which you asked about). I've bumped versions and have published versions 1.1.1 of the libraries. Please let me know if now it's passing fossa validation.

frankhaugen commented 2 years ago

@Drizin license scan is fine now, and thank you for polishing off my PR 😃