search

DrkMatr1984 / Piggyback

Ever wanted to CARRY pigs around like a BADASS?! Ever wanted a SLIME as PET?! TIRED of Wheat and Leads?! Your FRIEND doesn't want to come with YOU?! Then this is the Plugin for you!
GNU General Public License v2.0
3 stars 3 forks source link

Buggy Entities #1

Closed guidingarrow closed 6 years ago

guidingarrow commented 8 years ago

The following issues are caused when carrying certain entities using this plugin.

Allows User to fly by attempting to sit in/on: Boat (All types) Minecart

Prevents user from performing other actions: Storage Minecart Powered Minecart Minecart with TNT (Also explodes when thrown) Minecart with Hopper Ender Crystal (Explodes when hit) Anvil (all types)

Interferes with normal function: Horse

Prevents the user from being hit by other players: Sand (All types) Gravel Falling blocks in general. Note that it only prevents them from being hit if someone aims for their head. Anywhere else they still take damage.

Mobs/blocks that should probably be blocked: Giant Zombie (Not a big deal, shouldn't ever see one) Ender Dragon Wither Shulker Ghast (Large, completely blocks view, could be worked around) Slime (Large, completely block view, could be worked around) Primed TNT

All hostile mobs, villagers, and squids take damage if the player tries to hit anything. All players take damage if the player carrying them tries to hit anything. All friendly mobs take damage if the player tries to hit anything while sneaking. This happens regardless of the direction the player is looking.

Entity ID List: Primed TNT (PrimedTnt) 20, Falling Block (FallingSand) 21, Minecart with Command Block (MinecartCommandBlock) 40, Boat (Boat) 41, Minecart (MinecartRideable) 42, Storage Minecart (MinecartChest) 43, Powered Minecart (MinecartFurnace) 44, Minecart with TNT (MinecartTNT) 45, Minecart with Hopper (MinecartHopper) 46, Minecart with Spawner (MinecartSpawner) 47, Giant Zombie (Giant) 53, Slime (Slime) 55, Ghast (Ghast) 56, Ender Dragon (EnderDragon) 63, Wither (WitherBoss) 64, Shulker (Shulker) 69, Squid (Squid) 94. Villager (Villager) 120, Ender Crystal (EnderCrystal) 200, Hostile Mobs 50 to 69, Friendly Mobs 90 to 101. Obtained from here: http://minecraft-ids.grahamedgecombe.com/entities

Let me know if you need any additional detail.

DrkMatr1984 commented 8 years ago

All friendly mobs take damage if the player tries to hit anything while sneaking.

Do you mean sneaking and attacking bypasses pvp protections when this plugin is enabled? Because you can normally sneak and punch friendly mobs while sneaking unless there's something preventing that.

DrkMatr1984 commented 8 years ago

Btw, I am addressing as many of these issues as possible currently.

guidingarrow commented 8 years ago

If I remember correctly I meant that when carrying a friendly mob they would take damage if you were sneaking and tried to attack something else. Whereas if you were to try to attack something else while not sneaking the carried mob does not take damage.

I'll try and confirm this after work if you don't have it figured out by then.

DrkMatr1984 commented 8 years ago

ok, thanks. Yeah I have to work in an hour, so probably not gonna mess with it anymore tonight. But I wanted to start the ball rolling and get the fixes done :)

DrkMatr1984 commented 8 years ago

Yup, you were right. I'm trying to look into that currently. I fixed the text bug and added some blacklists. I also noticed a few more potential bugs when browsing the code and fixed those. The flying with boats is caused by an exception in MC itself due to a circular riding error. (ie. you're riding the boat while the boat is riding you) I've been trying to solve the root cause of this as it happens when carrying any vehicle in 1.9+ with my plugin. There's also a few more features being added. Check out the issue logs.

DrkMatr1984 commented 7 years ago

Still solving some of these issues. Working on cleaning up the code and solving as many as possible.

DrkMatr1984 commented 7 years ago

Allows User to fly by attempting to sit in/on: Boat (All types) Minecart

Prevents user from performing other actions: Storage Minecart Powered Minecart Minecart with TNT (Also explodes when thrown) Minecart with Hopper Ender Crystal (Explodes when hit) Anvil (all types)

Interferes with normal function: Horse

Prevents the user from being hit by other players: Sand (All types) Gravel Falling blocks in general. Note that it only prevents them from being hit if someone aims for their head. Anywhere else they still take damage.

Mobs/blocks that should probably be blocked: Giant Zombie (Not a big deal, shouldn't ever see one) Ender Dragon Wither Shulker Ghast (Large, completely blocks view, could be worked around) Slime (Large, completely block view, could be worked around) Primed TNT

All hostile mobs, villagers, and squids take damage if the player tries to hit anything. All players take damage if the player carrying them tries to hit anything. All friendly mobs take damage if the player tries to hit anything while sneaking. This happens regardless of the direction the player is looking.

Entity ID List: Primed TNT (PrimedTnt) 20, Falling Block (FallingSand) 21, Minecart with Command Block (MinecartCommandBlock) 40, Boat (Boat) 41, Minecart (MinecartRideable) 42, Storage Minecart (MinecartChest) 43, Powered Minecart (MinecartFurnace) 44, Minecart with TNT (MinecartTNT) 45, Minecart with Hopper (MinecartHopper) 46, Minecart with Spawner (MinecartSpawner) 47, Giant Zombie (Giant) 53, Slime (Slime) 55, Ghast (Ghast) 56, Ender Dragon (EnderDragon) 63, Wither (WitherBoss) 64, Shulker (Shulker) 69, Squid (Squid) 94. Villager (Villager) 120, Ender Crystal (EnderCrystal) 200, Hostile Mobs 50 to 69, Friendly Mobs 90 to 101. Obtained from here: http://minecraft-ids.grahamedgecombe.com/entities

Let me know if you need any additional detail.

DrkMatr1984 commented 7 years ago

Making a dent. Fixed most of these simply by limiting entities allowed to be picked up to LivingEntities only. I will probably allow all mobs, as it's kind of the intent of the plugin. I added a blacklist to the config though which should allow users to block some of the LivingEntities they don't want to be picked up from being picked up.

DrkMatr1984 commented 6 years ago

Most of these errors fixed in 2.0, closing this issue.