DrkSephy / django-hackathon-starter

A boilerplate for Django web applications
1.61k stars 298 forks source link

Implement Facebook Login #3

Closed DrkSephy closed 9 years ago

DrkSephy commented 9 years ago

One of the most common sign-in methods (Facebook) has not been implemented. Users often fall back to using this method, so it should be a high priority to get it done.

DrkSephy commented 9 years ago

For reference, we're currently using this library for handling OAuth.

lsxliron commented 9 years ago

Please review the code and merge

DrkSephy commented 9 years ago

I don't see a pull request, did you not send one in?

lsxliron commented 9 years ago

Sorry. Long day. You should have it now...

DrkSephy commented 9 years ago

Regarding the Facebook login, I believe there is a configuration that needs to happen on your end. When trying to log in, this is the error I am getting:

app

lsxliron commented 9 years ago

I sent a pull request and changed the app status. Suppose to be working now

DrkSephy commented 9 years ago

Implemented by #8