search

Droei / Droei-RuneLite-Plugins

A Runelite plugin that allows you to pet Capybara's in Runescape
2 stars 0 forks source link

[Entity Masker] Massive performance cost #1

Open fuzxi opened 5 months ago

fuzxi commented 5 months ago

With the plugin enabled, all settings unchecked, and the NPC list empty, my frame rate at the GE is hovering between 20-40 FPS. Disabling the plugin, my FPS immediately jumps up to 144 and locks there. Why is there such a huge performance hit when it's not even masking any NPCs?

Droei commented 5 months ago

That's weird, I myself haven't noticed that yet. I'll look into it thanks for letting me know!

IllumiC commented 3 months ago

Recreated with this .properties file (+default entity masker without jad images) Liam.txt 10fps north lumbridge chickens, 20fps lumbridge castle.

Edit: But I must say that I love the plugin

peakjcw commented 2 months ago

I'm confirming the same issue. Even with nothing to mask, enabling the plugin drops my FPS from 60+ to 10-20. My FPS sticks at 60 everywhere from Fossil Island to the GE on W302 unless Entity Masker is on. The issue gradually gets worse over the course of 30 minutes or so from starting up RuneLite.

It's a shame too, because seeing bugs even in OSRS makes me very ill and this plugin was a lifesaver that I very much appreciate. At least I can toggle it on when really needed.

Droei commented 2 months ago

Hi there! Thanks for confirming, I also got it confirmed by others in private too and I could recreate the problem on my device! I've been very busy lately so I couldn't get to it yet but I am planning to update all my plugins soon.

Also on a side @peakjcw if you want me to I can take your list of bugs and put it into the plugin as a default option together with the other phobias!

I will get back to this problem soon and keep y'all updated! Thanks for using my plugin!

Droei commented 2 months ago

Hi everyone!

Sorry that I've been this late with this, life has been busy and I procrastonated a little. I have found the issue, the performance drop comes from the jad images, disabling Show Images should resolve the issue and I will push out a new update soon to temporary disable the option by default. Once things settle down a little on my side I hope to redo that code to be more performance friendy and customisable!

Thanks for your patience and for using my plugin!

IllumiC commented 2 months ago

Hey, I've been experiencing performance drops with the Jad images disabled.

On Thu, 29 Aug 2024, 11:20 Droei, @.***> wrote:

Hi everyone!

Sorry that I've been this late with this, life has been busy and I procrastonated a little. I have found the issue, the performance drop comes from the jad images, disabling Show Images should resolve the issue and I will push out a new update soon to temporary disable the option by default. Once things settle down a little on my side I hope to redo that code to be more performance friendy and customisable!

Thanks for your patience and for using my plugin!

— Reply to this email directly, view it on GitHub https://github.com/Droei/Droei-RuneLite-Plugins/issues/1#issuecomment-2317123754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJU6MSRP3YVWYB6T3FUVCYLZT3RWFAVCNFSM6AAAAABIIQNBUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXGEZDGNZVGQ . You are receiving this because you commented.Message ID: @.***>

peakjcw commented 2 months ago

Yeah I should have clarified before but I was always having issues with the images off.

Droei commented 2 months ago

Damn alright I also read that indeed everything was off. Sorry about that, I could only recreate the issue when I was messing with the images.

I'd love to hear what people experiencing these problems use in their desktop: CPU, GPU & Ram. Asking this to check if its anything hardware related

IllumiC commented 2 months ago

I'm on a 11700k, 3060 12gb, 16gb ram. My girlfriend experiences the issue in her similar amd system. Haven't been on osrs much but next time I'm on I'll have a go seeing if it's any other plugin causing it.

On Fri, 30 Aug 2024, 00:13 Droei, @.***> wrote:

Damn alright I also read that indeed everything was off. Sorry about that, I could only recreate the issue when I was messing with the images.

I'd love to hear what people experiencing these problems use in their desktop: CPU, GPU & Ram. Asking this to see if that to figure out why I can't recreate the problem myself

— Reply to this email directly, view it on GitHub https://github.com/Droei/Droei-RuneLite-Plugins/issues/1#issuecomment-2319138003, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJU6MSUVBZCQI4726EJGYNTZT6MHHAVCNFSM6AAAAABIIQNBUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJZGEZTQMBQGM . You are receiving this because you commented.Message ID: @.***>

Droei commented 2 months ago

That is better than my current setup, I used to have a high end setup but now its 6y old and I'm having a lot of problems with it lately. But for some reason it just doesn't lagg with entity masker (unless images are on) so maybe it is indeed a plugin thing.

Still definitly something that needs to be resolved so I'll take any info I can get!