Closed rdeodoo closed 5 years ago
@rdeodoo i was working on POC to get debug information from the session. I have fetched debug information without injecting the script in page. Somewhat like this, https://gist.github.com/pga-odoo/c3498e3ba31c6c84ae3b1d210713a88f but i think your version is more robust. Have you tested your code for the older version of odoo?
@rdeodoo @mart-e I didn't get enough time to improve the extension, but i was planning to give triple click(test assets mode) as an option because this extension is also used by non developers(end-user, functional experts, consultant etc.) and i think they don't not need debug test assets option. Some what like:
I will develop something this weekend and let you know for feedback.
Have you tested your code for the older version of odoo?
No, I planned to add the support for older version (fallback on URL as before) once it was ok for master (right now it still shows error on extension console I think). Aside that, the code works fine in master (both for activation on click and for retrieving the debug state on tab load/switch).
but i was planning to give triple click(test assets mode) as an option
Honestly, if they don't need it, I don't think it will be annoying for them, they won't triple click on the extension by error :yum:
Let me know if you want/need me to keep working on this PR, eg adding the support for older version so the code is working with every versions.
@rdeodoo You can continue work on this PR. Just a few remarks:
?debug=tests
(we will think about it later after merging this PR)Thanks for your work :+1: .
Merged at https://github.com/pga-odoo/OdooDebug/pull/6 Thanks @rdeodoo for your work :+1:. We will implement test mode in later version.
@mart-e @pga-odoo Could you have a look? First time I work with browser extension, a lot might be wrong :yum:.
I was working on that just before merging the task, this is not done but worth having a look. As retrieving current debug mode can't rely on URL and we did not want to add any data-attribute in odoo standard, the only way to retrieve it is to read odoo.debug. Which can only be done by injecting a script apparently.
I also used the robot for tests assets.
@mart-e As I saw you were working on this too, that's why I thought I would add the current work here. Once it looks ok for the master debug version, I will simply add a fallback for older versions that will rely on URL if odoo.debug does not exists.