search

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

fix wrong label #290

Closed noboru-i closed 7 years ago

noboru-i commented 7 years ago

Issue

Overview (Required)

Links

Screenshot

None

By the way, we really need android:label property for not LAUNCHER Activity...? https://developer.android.com/guide/topics/manifest/activity-element.html?hl=ja#label

konifar commented 7 years ago

Good catch! ⚾️ LGTM! 💯

konifar commented 7 years ago

Thanks for contribution!

noboru-i commented 7 years ago

Thanks!

Sorry for small changes... :sweat_smile:

konifar commented 7 years ago

By the way, we really need android:label property for not LAUNCHER Activity...?

Hmm, I'm not sure. But it looks unnecessary. Let me investigate more.

konifar commented 7 years ago

Sorry for small changes... 😅

Actually I didn't know this issue. So this PR is really worth for us 👍