Remove unused SessionFeedbackViewModel injection.

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo

Apache License 2.0

470 stars 140 forks source link

Closed k-kagurazaka closed 7 years ago

k-kagurazaka commented 7 years ago

None

SessionFeedbackViewModel is not used in SessionFeedbackActivity so I have removed it's injection.

konifar commented 7 years ago

Thanks! Maybe this viewmodel will be used when we will implement feedback page. But it's okay to remove it now.

konifar commented 7 years ago

LGTM!

k-kagurazaka commented 7 years ago

I think that feedback page will be implemented in SessionFeedbackFragment and the activity simply has this fragment. Do I misunderstand something?