More MVVM for Contributors view - Githubissues

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo

Apache License 2.0

470 stars 140 forks source link

More MVVM for Contributors view #304

Closed k-kagurazaka closed 7 years ago

k-kagurazaka commented 7 years ago

Issue

None

Overview (Required)

The purpose of this PR is ContributorsFragment makes thin and ContributorsViewModel makes testable.

Apply MVVM pattern to Toolbar title.
Move logic (rendering contributors) from ContributorsFragment to ContributorsViewModel.
Add tests for ContributorsViewModel.

konifar commented 7 years ago

Cool 🆒 Thanks for interesting suggestion! I'm afraid it makes other contributors confused 💭
Please let me consider 🙇

konifar commented 7 years ago

I think it's a little complicated and too much for me 🤔 Please let me consider 🙇

Finally I agree your suggestion. It's awesome. As you said, this PR makes easy to test and it's not so complicated for me 👍 I learned a lot from this! Let's apply this pattern to other ViewModels!

konifar commented 7 years ago

LGTM!! But sorry, conflict occurred. Can you merge master?

k-kagurazaka commented 7 years ago

I resolved conflicts 👍

konifar commented 7 years ago

Thank you for corresponding till late at midnight (morning?) 😄

k-kagurazaka commented 7 years ago

No problem. Thank YOU!

konifar commented 7 years ago

Here we go!