search

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

Remove unnecessary packagingOptions #326

Closed shiraji closed 7 years ago

shiraji commented 7 years ago

Issue

-

Overview (Required)

There are 2 packagingOptions in app/build.gradle. Let's combine them.

BTW, do we really need exclude 'LICENSE.txt'???

Remove unnecessary packagingOptions

Links

-

Screenshot

Before After
konifar commented 7 years ago

Thanks!

BTW, do we really need exclude 'LICENSE.txt'

I can't remember why I added this 🤔 Maybe the build error occurred by some of library's LICENSE.txt. If you can build without this exclude option, it's unnecessary.

shiraji commented 7 years ago

If you can build without this exclude option, it's unnecessary.

Let me check

shiraji commented 7 years ago

Yea. In my machine, no error happens if I remove the setting.

Squashed the commits.

konifar commented 7 years ago

Thanks! LGTM! 💯