search

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

White space appeared when scrolling and rotating in sessions page #327

Open gen0083 opened 7 years ago

gen0083 commented 7 years ago

Overview (Required)

Reproduce step

  1. scroll down to session's position started at 11:50
  2. rotate the device
  3. scroll up a little
  4. rotate the device again
  5. scroll up to top of the sessions then white space appeared

Links

Screenshot

ezgif com-video-to-gif

konifar commented 7 years ago

It looks TwoWayView bug 😢

KeithYokoma commented 7 years ago

Similar bug when you launch the app in landscape mode and then rotate to portrait 😢

jmatsu commented 7 years ago

Ah sorry, actually it's not twoway-view bug. 🐍 The hight of recycler view is fixed because of fixing another bug. We need to reinit the height when configuration is changed. https://github.com/DroidKaigi/conference-app-2017/blob/c8f6918ceb46d0016033de874a15d8383dca484b/app/src/main/java/io/github/droidkaigi/confsched2017/view/fragment/SessionsFragment.java#L174

KeithYokoma commented 7 years ago

Got it!

konifar commented 7 years ago

Understood! Thanks! 👍