search

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

Separate the logic for animating the ParticleView into SplashFragment. #329

Closed YusukeIwaki closed 7 years ago

YusukeIwaki commented 7 years ago

Overview (Required)

Currently SplashActivity has 2 responsibility:

I think it would be more useful if the logic of animation is capsulized in a Fragment. This Pull Request provides SplashFragment for handling the ParticleView, and makes SplashActivity simpler.

Links

-

Screenshot

not changed. Just a refactoring :)

konifar commented 7 years ago

:eyes:

konifar commented 7 years ago

I think it would be more useful if the logic of animation is capsulized in a Fragment.

Make sense. I agree your opinion

konifar commented 7 years ago

LGTM 💯 Thanks! @roana0229 Can you check this just in case?